Failed to enable HTML5 Notifications Error Dialogs #827
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…changing Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
src/Notifier.js
Outdated
| @@ -131,6 +133,14 @@ const Notifier = { | |||
| plaf.requestNotificationPermission().done((result) => { | |||
| if (result !== 'granted') { | |||
| // The permission request was dismissed or denied | |||
| const description = result === 'denied' | |||
| ? 'Your browser is not permitting this app to send you notifications.' | |||
| : 'It seems you didn\'t accept notifications when your browser asked'; | |||
There was a problem hiding this comment.
I suggest:
"Riot does not have permission to send you notifications - please check your browser settings"
There was a problem hiding this comment.
do you suggest that for both the denied and default (they simply dismissed it) scenarios?
There was a problem hiding this comment.
oops, sorry, i missed this (and misread the ternary as a continuation the first time). How about this?
denied: "Riot does not have permission to send you notifications - please check your browser settings"
default: "Riot was not given permission to send notifications - please try again"
|
i added a comment for better wording - otherwise lgtm :) |
|
@t3chguy ptal |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
@ara4n PTAL |
|
thanks |
Would appreciate better wording for both scenarios
for element-hq/element-web#2569