This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement user power-level changes in timeline #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
suggested changes
Apr 6, 2017
src/TextForEvent.js
Outdated
| 50: 'Moderator', | ||
| 100: 'Admin', | ||
| }; | ||
|
|
There was a problem hiding this comment.
It feels like the sort of thing that should be in one place: we should probably reuse the logic from/in https://github.com/matrix-org/matrix-react-sdk/blob/master/src/components/views/elements/PowerSelector.js
src/TextForEvent.js
Outdated
| } else { | ||
| return level; | ||
| } | ||
| } |
There was a problem hiding this comment.
This should probably be common between here and PowerSelector too.
So that the mapping between a numerical power level and a "role" are done in one place. PowerSelector.js has been modified to use the same mapping.
dbkr
approved these changes
Apr 10, 2017
|
Merging after next release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#266
@alice:matrix.orgfrom 50 to 49,@ken:matrix.orgfrom 34 to 43, ..."