Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prevent crash on login of no guest session #769

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 23, 2017

The bound functions are only set when the Notifier is started, so
if stop() was called without start() having been called, the
listener function would be null which would throw an exception.

The bound functions are only set when the Notifier is started, so
if stop() was called without start() having been called, the
listener function would be null which would throw an exception.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but don't we have a test for this? Would it be worth adding on if not? These login edge-cases are fragile, and don't get enough manual testing.

@dbkr dbkr merged commit df15c9b into develop Mar 23, 2017
martindale pushed a commit to FabricLabs/matrix-react-sdk that referenced this pull request Dec 8, 2018
Fix: correctly check for crypto being present
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants