This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Show spinner whilst processing recaptcha response #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that we showed no feedback whilst submitting the captcha response was causing confusion on slower connections where this took a nontrivial amount of time. Takes a new flag from the js-sdk that indicates whether the request being made is a background request, presenting a spinner appropriately. Requires matrix-org/matrix-js-sdk#396
richvdh
reviewed
Mar 21, 2017
| this.setState({ | ||
| busy: true, | ||
| busy: !background, |
There was a problem hiding this comment.
sorry, I'm not quite grokking this. why do we only set busy if not background?
There was a problem hiding this comment.
Actually this was a bit silly (and buggy). I've updated it so it doesn't set the state at all for background requests, and commented it.
richvdh
suggested changes
Mar 22, 2017
| errorText: null, | ||
| stageErrorText: null, | ||
| }); | ||
| // only set the busy flag if this is a non-background request |
There was a problem hiding this comment.
well, I'm still not grokking it. A comment that says "do X" doesn't help me understand why X is the right thing to do :/
richvdh
approved these changes
Mar 22, 2017
This makes the code a bit neater.
martindale
pushed a commit
to FabricLabs/matrix-react-sdk
that referenced
this pull request
Dec 8, 2018
loglevel should be a normal dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that we showed no feedback whilst submitting the captcha
response was causing confusion on slower connections where this
took a nontrivial amount of time.
Takes a new flag from the js-sdk that indicates whether the
request being made is a background request, presenting a spinner
appropriately.
Requires matrix-org/matrix-js-sdk#396