This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't show link preview when link is inside of a quote #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lieuwe Rooijakkers <lieuwerooijakkers@gmail.com>
|
Can one of the admins verify this patch? |
lieuwex
commented
Mar 18, 2017
| @@ -131,7 +131,8 @@ module.exports = React.createClass({ | |||
| links.push(node); | |||
| } | |||
| } | |||
| else if (node.tagName === "PRE" || node.tagName === "CODE") { | |||
| else if (node.tagName === "PRE" || node.tagName === "CODE" || | |||
There was a problem hiding this comment.
I thought of using else if (["BLOCKQUOTE", "PRE", "CODE"].indexOf(node.tagName) > -1) { here since it's a bit shorter, but I guess it would take a pretty big hit in performance
There was a problem hiding this comment.
Seems like a good decision
|
The test failure is a Red Herring so LGTM |
|
Thanks! 🎉 |
martindale
pushed a commit
to FabricLabs/matrix-react-sdk
that referenced
this pull request
Dec 8, 2018
Add repository type to package.json to make it valid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#3445. Thought this issue was a good one to start contributing :)