This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a 'Clear Cache' button #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletes the IndexedDB database and reloads the page. This solely exists as a get-out clause for users in case the indexedDB instance gets corrupted. Hopefully we won't ever need to point users to it.
dbkr
reviewed
Feb 17, 2017
| @@ -418,6 +418,14 @@ module.exports = React.createClass({ | |||
| Modal.createDialog(BugReportDialog, {}); | |||
| }, | |||
|
|
|||
| _onClearCacheClicked: function() { | |||
| MatrixClientPeg.get().store.deleteAllData().then(() => { | |||
| return <div> | ||
| <h3>Clear Cache</h3> | ||
| <div className="mx_UserSettings_section"> | ||
| <AccessibleButton className="mx_UserSettings_button danger" |
There was a problem hiding this comment.
How dangerous is it to go alone clear the cache?
There was a problem hiding this comment.
You made a Zelda reference! /me swoons
It's deleting data, which I think is dangerous, and it will cause a long resync potentially which is bad. I don't have any strong feelings either way.
| <div className="mx_UserSettings_section"> | ||
| <AccessibleButton className="mx_UserSettings_button danger" | ||
| onClick={this._onClearCacheClicked}> | ||
| Clear Cache (triggers page refresh) |
There was a problem hiding this comment.
How about, "Clear Cache and Reload"?
dbkr
approved these changes
Feb 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the IndexedDB database and reloads the page.
This solely exists as a get-out clause for users in case the indexedDB instance
gets corrupted. Hopefully we won't ever need to point users to it.