This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make ban either ban or unban #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a specific dialog used for confirming member actions. Also remove onFinished from MemberInfo which did absolutely nothing.
depending on whether the user is banned already Mostly gives some feedback that the ban has actually taken effect.
lukebarnard1
suggested changes
Feb 14, 2017
| ).then( | ||
| let promise; | ||
| if (this.props.member.membership == 'ban') { | ||
| promise = this.props.matrixClient.unban( |
There was a problem hiding this comment.
onBan should probably have a different name given that it might unban someone
| @@ -481,22 +489,22 @@ module.exports = WithMatrixClient(React.createClass({ | |||
| }, | |||
|
|
|||
| _calculateCanPermissions: function(me, them, powerLevels) { | |||
There was a problem hiding this comment.
/me wishes this or something more generic for figuring out the client's abilities was pushed way further down the stack, potentially to the js-sdk
There was a problem hiding this comment.
Agreed this should definitely be in the js-sdk. Trying to put some limit on the depth of this rabbit hole traversal though.
|
ptal |
lukebarnard1
approved these changes
Feb 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on whether the user is banned already
Mostly gives some feedback that the ban has actually taken effect.
Includes #694 so either merge that first & merge in, or just look at the last commit.