This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
View /home on registered /w team #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Feb 10, 2017
| @@ -227,6 +227,9 @@ module.exports = React.createClass({ | |||
| const teamToken = data.team_token; | |||
| // Store for use /w welcome pages | |||
| window.localStorage.setItem('mx_team_token', teamToken); | |||
| // Set the team token and view homepage | |||
| window.matrixChat._teamToken = teamToken; | |||
| window.mxDispatcher.dispatch({action: 'view_home_page'}); | |||
There was a problem hiding this comment.
We shouldn't be accessing these through the window object. We should get the dispatcher by import dispatcher and probably pass the team token up with a callback prop.
Also, I'm a little skeptical about the view_home_page dispatch: is there not somewhere else that decides what page to display once registration is complete and can we do this there (are we going to race with it?)
There was a problem hiding this comment.
I'll add an extra callback prop that handles the team token.
dbkr
approved these changes
Feb 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.