Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

MELS: either expanded or summary, not both #683

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1
Copy link
Contributor Author

With the referenced SCSS, this looks like:
2017-02-09-151218_569x35_scrot
when collapsed and
2017-02-09-151213_574x128_scrot
when expanded.

@ara4n
Copy link
Member

ara4n commented Mar 2, 2017

so, the point of #3097 was both to avoid showing the duplicate MEL info between the summary & the expanded form... and to avoid wasting vertical space. Would it be possible to keep it simpler and just put the 'collapse' link at the end of the first line when expanded (e.g. @135542:matrix.org joined the room in your screenshot example)?

@ara4n
Copy link
Member

ara4n commented Mar 2, 2017

(aesthetically i quite like your proposal, but it does waste vertical space, and i'm not sure we need yet another visual idiom involved - especially as the HR looks a bit like a section break or similar)

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Mar 2, 2017
@lukebarnard1
Copy link
Contributor Author

Would it be possible to keep it simpler and just put the 'collapse' link at the end of the first line when expanded

This would be obscured by read receipts, hence it being above instead.

@lukebarnard1 lukebarnard1 merged commit e75c21e into develop Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants