Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix typing notif and status bar #682

Merged
merged 3 commits into from
Feb 9, 2017
Merged

Fix typing notif and status bar #682

merged 3 commits into from
Feb 9, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Feb 9, 2017

  • Use single state to set both avatars and typing notif
  • Use (props, state) ordering of arguments, there was a bug here that meant that sometimes arguments were given in the wrong order; presumably leading to the status bar not appearing for calls etc.
  • Do not show "+1 other", instead show a user name or avatar.

Should fix element-hq/element-web#3172, element-hq/element-web#3141, and possibly element-hq/element-web#3074

Luke Barnard added 3 commits February 9, 2017 10:01
There was a bug here that meant that sometimes arguments were given in the wrong order; presumably leading to the status bar not appearing for calls etc.
Instead show a user name or avatar.
@lukebarnard1 lukebarnard1 changed the title Fix typing notif Fix typing notif and status bar Feb 9, 2017
@dbkr dbkr merged commit 7ba9e27 into develop Feb 9, 2017
@lukebarnard1 lukebarnard1 deleted the luke/fix-typing-notif branch February 9, 2017 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very confused typing notifications
2 participants