This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use new method of getting team icon #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary because the team token may not be known when registering, but domain is. Storing the icon under the "common" directory is the chosen solution to this.
dbkr
reviewed
Feb 9, 2017
| "https://riot.im/rts/static/common/" + | ||
| this.state.teamSelected.domain + "/icon.png" : | ||
| null} | ||
| /> |
There was a problem hiding this comment.
Hang on, surely these should be hosted on the RTS? Otherwise each install of Riot now has to have an icon for each team it needs to support.
There was a problem hiding this comment.
yep, /rts/ points to the RTS server, which hosts the icons.
There was a problem hiding this comment.
Ah! Right. Should it not be based off the team server URL in the config then?
dbkr
approved these changes
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was necessary because the team token may not be known when registering, but domain is. Storing the icon under the "common" directory is the chosen solution to this.