Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make default avatars clickable #673

Merged
merged 3 commits into from
Feb 2, 2017
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 2, 2017

BaseAvatar can be passed an onClick which is called when it's, er,
clicked, except when it was the default avatar in which case it
merrily ignored it. Make it not ignore it.

BaseAvatar can be passed an onClick which is called when it's, er,
clicked, except when it was the default avatar in which case it
merrily ignored it. Make it not ignore it.
@dbkr dbkr requested a review from richvdh February 2, 2017 18:31
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er, let's not C&P this code.

either:

  • always use AccessibleButton even when onClick is null (we could make it not do the tabIndex stuff in that case?)
  • factor the common children out to a variable/funciton

@richvdh richvdh assigned dbkr and unassigned richvdh Feb 2, 2017
@dbkr
Copy link
Member Author

dbkr commented Feb 2, 2017

fair enough, ptal

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I think we expect multiline JSX to be wrapped in (), as per the returns. Makes it rather more readable...

@dbkr
Copy link
Member Author

dbkr commented Feb 2, 2017

done, ptaal

@richvdh richvdh merged commit cd5a1ab into develop Feb 2, 2017
@richvdh richvdh deleted the dbkr/make_default_avatars_clickable branch February 15, 2017 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants