This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add referral section to user settings #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows those who have registered to referrer other students to Riot and have their referral counted for the campaign competition.
dbkr
reviewed
Jan 31, 2017
| return null; | ||
| } | ||
| const href = window.location.origin + | ||
| `/#/register?referrer=${this._me}&team_token=${teamToken}`; |
There was a problem hiding this comment.
Bear in mind this won't work in the electron app as your window.href will be a file URI. Are we supporting team-based stuff in electron? I guess we can do if we ship the appropriate config.
There was a problem hiding this comment.
Having spoken to @BenfLewis0, there's no reason why electron users wouldn't have referral links. Making this configurable would probably be desirable.
lukebarnard1
commented
Jan 31, 2017
| @@ -57,7 +57,7 @@ module.exports = React.createClass({ | |||
| // URL of the riot-team-server to get team configurations and track referrals | |||
| teamServerURL: React.PropTypes.string.isRequired, | |||
| }), | |||
| teamSelected: null, | |||
| teamSelected: React.PropTypes.object, | |||
There was a problem hiding this comment.
Fixes a warning
dbkr
approved these changes
Jan 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows those who have registered to referrer other students to Riot and have their referral counted for the campaign competition.