This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add bug report UI #642
Merged
Add bug report UI #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
suggested changes
Jan 24, 2017
There was a problem hiding this comment.
Once it's hooked up, sure. :)
New warnings (why jenkins is failing): http://matrix.org/jenkins/job/ReactSDKPR/883/checkstyleResult/new/
| @@ -0,0 +1,122 @@ | |||
| /* | |||
| Copyright 2016 OpenMarket Ltd | |||
| const userText = this.state.text; | ||
| if (!sendLogs && userText.trim().length === 0) { | ||
| this.setState({ | ||
| err: "Please describe the bug and/or send logs." |
There was a problem hiding this comment.
I thought we always wanted at least a brief description of what happened, even if we have logs?
There was a problem hiding this comment.
I don't mind which we do. I think we're likely to get more feedback if we make the description optional, but YMMV. Let me know what you want me to do.
|
Waiting on element-hq/element-web#3000 . |
dbkr
approved these changes
Jan 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#3045