Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

New feature: marking rooms as unread [MSC2867] #6314

Closed
wants to merge 18 commits into from
Closed

New feature: marking rooms as unread [MSC2867] #6314

wants to merge 18 commits into from

Commits on Jan 10, 2022

  1. new feature: marking rooms as unread [MSC2867] 

    Signed-off-by: chandi <git@chandi.it>
    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2e84df2 View commit details
    Browse the repository at this point in the history

  2. single place for unread state retrieval and changing 

    Signed-off-by: chandi <git@chandi.it>
    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    49451cd View commit details
    Browse the repository at this point in the history

  3. 'mark as unread' feature behind labs flag 

    Signed-off-by: chandi <git@chandi.it>
    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2ff656f View commit details
    Browse the repository at this point in the history

  4. remove unnecessary checks 

    Signed-off-by: chandi <git@chandi.it>
    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2f90208 View commit details
    Browse the repository at this point in the history

  5. reduce notification state updates, less generic name for watcher ref 

    Signed-off-by: chandi <git@chandi.it>
    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    0e5cad7 View commit details
    Browse the repository at this point in the history

  6. Render marked-as-unread badge as green exclamation mark

    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6b28f80 View commit details
    Browse the repository at this point in the history

  7. Only show "mark as unread" if applicable (i.e., room not already unread)

    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    66bb12f View commit details
    Browse the repository at this point in the history

  8. Add own icons for mark as (un)read 

    From Google's material design icons:
https://fonts.google.com/icons?selected=Material+Icons&icon.query=eye

License: https://google.github.io/material-design-icons/
"We have made these icons available for you to incorporate them into
your products under the Apache License Version 2.0. Feel free to remix
and re-share these icons and documentation in your products. We'd love
attribution in your app's about screen, but it's not required. The only
thing we ask is that you not re-sell the icons themselves."
    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e5810fb View commit details
    Browse the repository at this point in the history

  9. Fix NPE related to mark-as-unread 

    TypeError: Cannot read property 'getAccountData' of null
    at d (Rooms.ts:160)
    at e.removeUnreadMarker (TimelinePanel.tsx:884)
    at e.<anonymous> (TimelinePanel.tsx:1140)
    at ui (react-dom.production.min.js:131)
    at ps (react-dom.production.min.js:220)
    at wc (react-dom.production.min.js:259)
    at t.unstable_runWithPriority (scheduler.production.min.js:18)
    at jo (react-dom.production.min.js:122)
    at xc (react-dom.production.min.js:252)
    at pc (react-dom.production.min.js:243)

when you have the panel for mentions open.
    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    62b4841 View commit details
    Browse the repository at this point in the history

  10. Add "mark as read" action

    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    e509a58 View commit details
    Browse the repository at this point in the history

  11. Muted rooms may also be rendered as "marked as unread"

    @SpiritCroc @alangecker
    SpiritCroc authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    0a63fb0 View commit details
    Browse the repository at this point in the history

  12. Appease linter

    @su-ex @alangecker
    su-ex authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c1fd33a View commit details
    Browse the repository at this point in the history

  13. Remove focus from room tile after hiding menu

    @su-ex @alangecker
    su-ex authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1ac2201 View commit details
    Browse the repository at this point in the history

  14. Show home if current room is marked unread

    @su-ex @alangecker
    su-ex authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    26d1219 View commit details
    Browse the repository at this point in the history

  15. Use UnstableValue class from matrix-js-sdk

    @su-ex @alangecker
    su-ex authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6dcd393 View commit details
    Browse the repository at this point in the history

  16. Mark unread: Fix marking current room as unread jump out 

    ToDo: Do this also if marked as unread on other device
    @su-ex @alangecker
    su-ex authored and alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    25e7554 View commit details
    Browse the repository at this point in the history

  17. feature_mark_unread: add missing labsGroup

    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1404586 View commit details
    Browse the repository at this point in the history

  18. make linter happy, missing i18n string, clean up

    @alangecker
    alangecker committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    d0a33ad View commit details
    Browse the repository at this point in the history