This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add ways to manage addresses for Spaces #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… t3chguy/fix/17244
…t with a className
… t3chguy/fix/17244 � Conflicts: � src/components/views/spaces/SpaceCreateMenu.tsx
nadonomy
approved these changes
Jun 17, 2021
turt2live
reviewed
Jun 22, 2021
src/components/views/settings/tabs/room/AdvancedRoomSettingsTab.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| // TODO: [REACT-WARNING] Move this to constructor |
There was a problem hiding this comment.
fwiw this was left behind because doing so caused crashes on user/room settings, and sometimes app-wide crashes. I presume it's been fixed, either intentionally or by accident over the last while?
… t3chguy/fix/17244 � Conflicts: � src/components/views/room_settings/AliasSettings.tsx
turt2live
approved these changes
Jun 22, 2021
|
E2E test passed, benchmark upload failed |
This was referenced Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#17244
https://www.figma.com/file/baCEQP0BvtuitBJUAtapoc/Spaces-Beta?node-id=4681%3A699