Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show the error dialog when requests to PUT power levels fail #614

Merged
merged 2 commits into from
Jan 13, 2017

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Jan 13, 2017

This is why I dislike Q.

Fixes element-hq/element-web#2944

@kegsay kegsay added the bug label Jan 13, 2017
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, would putting a .done() on the end here have caught the fail in the error handler?

@@ -376,6 +376,7 @@ module.exports = WithMatrixClient(React.createClass({
// get out of sync if we force setState here!
console.log("Power change success");
}, function(err) {
var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const please :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kegsay
Copy link
Member Author

kegsay commented Jan 13, 2017

Also, would putting a .done() on the end here have caught the fail in the error handler?

Yes. Have added.

@kegsay kegsay merged commit 07b3c58 into develop Jan 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants