This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Unbranded error messages #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Yup, you're absolutely right. Unfortunately the layering between Riot & matrix-react-sdk started off well and then got quite badly coupled during very rapid iteration on Riot, and we've not yet decoupled them properly (although hope to do so during 2017, especially with help like this!). This is a great start in the right direction - thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand, in the long run, matrix-react-sdk is intended as an SDK that client authors (like Riot) can use to implement a matrix client. As such, I think having error messages which avoid reference to a specific client will make implementer's lives easier.
There are two other references to Riot that I am aware of that this pull request does not address:
src/components/structures/MatrixChat.js line 922
src/components/views/elements/AddressTile.js line 78
I'm not presently familiar enough with this codebase to understand how those references should best be addressed.
Signed-off-by: Daniel Dent matrixcontrib@contactdaniel.net