Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't throw exception on stop if no DMRoomMap #589

Merged
merged 2 commits into from
Dec 9, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 9, 2016

Prevents an exception when running the riot 'loading' tests in isolation

(Includes #587)

For some reason, update webpack causes the promise to no longer
complete by the next tick. Change the test to not depend on how
fast the promise goes through.
Prevents an exception when running the riot 'loading' tests in
isolation
@dbkr dbkr requested a review from richvdh December 9, 2016 10:35
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richvdh richvdh assigned dbkr and unassigned richvdh Dec 9, 2016
@dbkr dbkr merged commit aed5a95 into develop Dec 9, 2016
@dbkr dbkr deleted the dbkr/dont_crash_if_no_dmroommap branch December 14, 2016 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants