Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix exception when clearing room dir search #585

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Fix exception when clearing room dir search #585

merged 1 commit into from
Dec 6, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 6, 2016

Needed more isMounted checks after promises return.

@dbkr
Fix exception when clearing room dir search
9e3c94e 
Needed more isMounted checks after promises return.
richvdh
richvdh approved these changes Dec 6, 2016
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum. This used to be ok, because checkFillState has its own unmounted check.

lgtm though

@richvdh richvdh merged commit 587325b into develop Dec 6, 2016
@dbkr dbkr deleted the dbkr/fix_exception_roomdir branch December 14, 2016 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees

@richvdh richvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @richvdh