Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Initial Spaces feature flag #5668

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Initial Spaces feature flag #5668

merged 4 commits into from
Feb 25, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 19, 2021

@t3chguy
Create Labs flag for Spaces
148764a
@t3chguy
Switch RoomListStore to only including the filtered subset
6b3f05a 
Without this it'd include notification counts from Community B when Community A is selected and such.
@t3chguy
First special treatment of space-rooms
79daf61
@t3chguy t3chguy requested a review from a team February 19, 2021 14:26
jryans
jryans reviewed Feb 22, 2021
View reviewed changes
src/settings/Settings.ts Outdated Show resolved Hide resolved
jryans
jryans suggested changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document the new flag in element-web as well.

src/settings/Settings.ts Show resolved Hide resolved
Base automatically changed from t3chguy/spaces1 to develop February 25, 2021 11:21
@t3chguy t3chguy mentioned this pull request Feb 25, 2021
Merged
@t3chguy t3chguy requested a review from jryans February 25, 2021 12:24
@t3chguy t3chguy merged commit 0f0e6c3 into develop Feb 25, 2021
@t3chguy t3chguy deleted the t3chguy/spaces2 branch February 25, 2021 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @jryans