This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update EventTile to use WithMatrixClient instead of MatrixClientPeg #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbkr: wdyt about this? Switching from MatrixClientPeg to the React context is the approach we agreed to, but is adding a layer of wrapping around every EventTile going to add further to memory/CPU usage woes? |
dbkr
reviewed
Nov 14, 2016
Now that EventTile expects MatrixClient in the context, we had better provide it.
|
Indeed they did. PTAL. |
dbkr
approved these changes
Nov 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.