This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Give our input fields names #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise browsers' 'Remember Password' feature has to guess badly and ends up putting the login username / password in the first two password reset fields which is a bit odd.
dbkr
commented
Oct 14, 2016
| @@ -96,10 +96,12 @@ module.exports = React.createClass({displayName: 'PasswordLogin', | |||
| <div> | |||
| <form onSubmit={this.onSubmitForm}> | |||
| <input className="mx_Login_field" type="text" | |||
| name="username" // make it a little easier for browser's remember-password | |||
There was a problem hiding this comment.
Note this will mean anyone why's already told chrome to remember their passwords will have to re-enter their credentials. We could remove this if we're not happy with that: I figure it's better to have them and if so we'd better do it sooner rather than later.
|
LGTM. Presumably element-hq/element-web#2462 is a similar problem? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise browsers' 'Remember Password' feature has to guess
badly and ends up putting the login username / password in the
first two password reset fields which is a bit odd.
Fixes element-hq/element-web#2469