This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Directory search join button #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch input to controlled so we re-render when it changes so we can show/hide the join button
richvdh
suggested changes
Sep 26, 2016
| } | ||
| } | ||
|
|
||
| _contentLooksLikeAlias() { |
There was a problem hiding this comment.
what's with some of the internal functions having _, and some not? I'd prefer it if they all had _, but at least be consistent.
There was a problem hiding this comment.
The logic, ftr, was treating functions passed to other bits (ie. the react callbacks) as public facing.
| if (!this.input) return false; | ||
|
|
||
| // liberal test for things that look like room aliases | ||
| return /#.+:.+/.test(this.state.value); |
There was a problem hiding this comment.
this matches abc#def:abc. You probably want /^#.+:/
|
ptal |
richvdh
approved these changes
Sep 26, 2016
| if (!this.input) return false; | ||
|
|
||
| // liberal test for things that look like room aliases | ||
| return /^#.+:.+/.test(this.state.value); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement 'join' button that appears in room directory search box when you type a valid(ish) alias.
Also factors out the directory search box to a different component now it's a lot more complex (and also adds the clear button that was in the designs).
Fixes element-hq/element-web#2217