Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wmwragg/remove old filter #475

Merged
merged 3 commits into from
Sep 15, 2016
Merged

Wmwragg/remove old filter #475

merged 3 commits into from
Sep 15, 2016

Conversation

wmwragg
Copy link
Contributor

@wmwragg wmwragg commented Sep 15, 2016

A companion branch vector-im/vector-web:wmwragg/remove-old-filter also needs to be merged.

Signed-off-by: William Wragg wm.wragg@gmail.com

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

@ara4n
Copy link
Member

ara4n commented Sep 15, 2016

lgtm, but do we still need the rate_limited_function on the search results to avoid chewing CPU every time you hit a letter on filtering 15K users?

@wmwragg
Copy link
Contributor Author

wmwragg commented Sep 15, 2016

@ara4n I don't think so, as the onSearchQueryChanged function just fires a setState React event, which I believe is already rate limited, multiple setStates won't all fire, and the search update is done on Render

@ara4n ara4n merged commit 2bd4089 into develop Sep 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants