This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix paste image to upload #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
suggested changes
Jun 1, 2020
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Palid
pushed a commit
that referenced
this pull request
Nov 25, 2021
Palid
pushed a commit
that referenced
this pull request
Nov 25, 2021
dbkr
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Fix links being parsed as markdown links improperly Fixes #4674 * Fix a typo * Fix overriding too much stuff * Fix parsing * Remove useless console.log * Remove unnecessary emph function * Properly fix tests * Add some better docs * Add missing license header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9852
Fixes element-hq/element-web#10795
We didn't prevent paste from pasting text even if we handled it as an image. We also used a react event handler for one and a dom one for the other.
Between paste and the modal showing up we queried the server for its media limits which is sometimes slow and users may try to paste again, now we instantly show a spinner modal briefly to prevent this.
I was able to reproduce both issues