Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Simple password strength test and improved user guidance during password reset #4673

Closed
wants to merge 5 commits into from

Conversation

peter-scholtens
Copy link

To guide the user when requesting a new password, the submit button in invalidated until a (most likely) correct e-mail address, a new password and password conformation are given. For each phase a new description on this button is added. This blocks filling in usernames or matrixID or other strings which cannot be a correct e-mail address. It does not validate the existence of an e-mail address.
This should solve issue element-hq/element-web#9978

…e created.

To guide the user when requesting a new password, the submit button in invalidated until a (most likely) correct e-mail address,  a new password and password conformation are given. For each state a new description on the button is added. This blocks filling in usernames or matrixID or other strings which cannot be an e-mail address. It does not validate the existence of an e-mail address.
This should solve issue element-hq/element-web#9978
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a number of utilities and components which help with this sort of validation - please use them instead of creating a new thing. I believe they are used on the registration page, if not in settings.

Also asking for product review to determine if this is something we want to support on this form, or if we're looking to generally improve password resets as part of FTUE.

@turt2live turt2live requested a review from a team June 1, 2020 13:19
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, to echo the same, this should just use the same validation/components than we use in login.

@jryans
Copy link
Collaborator

jryans commented Mar 4, 2021

Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #element-dev:matrix.org to find a good approach forward.

@jryans jryans closed this Mar 4, 2021
@peter-scholtens peter-scholtens deleted the patch-1 branch March 7, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants