Fix linkification and bump linkifyjs dep #460
Conversation
|
Can one of the admins verify this patch? |
| @@ -36,7 +36,7 @@ | |||
| "fuse.js": "^2.2.0", | |||
| "glob": "^5.0.14", | |||
| "highlight.js": "^8.9.1", | |||
| "linkifyjs": "2.0.0-beta.4", | |||
| "linkifyjs": "2.1.0", | |||
There was a problem hiding this comment.
the reason this was pinned to that particular version was due to element-hq/element-web#2010 - can you check it doesn't reintroduce that regression?
There was a problem hiding this comment.
It does, I'll update and revert this change. The actual fix here is to modify the states and transitions used, so that is all that's required.
|
@dbkr is probably best placed to review this one, as he did the linkify stuff in the first place iirc |
|
@matrixbot test this please |
|
Looks reasonable, assuming this is essentially adding in some extra characters to the set that are matched for aliases and cleaning up the inheritance. Guess we will need to pin the dependency again though. |
|
i'll merge and re-pin. |
|
this broke everything - i assume it's using 2.1.0 specific stuff? reverting... |
No description provided.