This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix bug whereby refreshing Vector would not allow querying of membership state #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hip state This was caused by Vector only sending a room alias with the `view_room` action. We now resolve this to a room ID if we don't have a room ID.
| sendError(event, "Must be viewing a room"); | ||
| } | ||
| // no room ID but there is an alias, look it up. | ||
| console.log("Looking up alias " + currentRoomAlias); |
There was a problem hiding this comment.
currentRoomAlias could be falsy?
There was a problem hiding this comment.
oops, right you are. Thanks. Done.
|
LGTM apart from comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by Vector only sending a room alias with the
view_roomaction.We now resolve this to a room ID if we don't have a room ID.