Scalar Messaging: Expose join_rules and restrict to currently viewed room #443
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
| @@ -193,12 +194,16 @@ function getMembershipState(event, roomId, userId) { | |||
| returnStateEvent(event, roomId, "m.room.member", userId); | |||
| } | |||
|
|
|||
| function getJoinRules(event, roomId) { | |||
| console.log(`join_rules of ${roomId} requested.`); | |||
| returnStateEvent(event, roomId, "m.room.join_rules"); | |||
There was a problem hiding this comment.
Needs a state_key of "":
returnStateEvent(event, roomId, "m.room.join_rules", "");
Bwahahaha, no. Aside from running locally, there is little more you can do. The architecture makes mocking hard (singletons forces you to use something like We could split this lot out into a class, inject the |
- use an empty state key - swap switch for if - s/not in view/not visible/
|
LGTM aside from |
|
@kegsay pls take another look, I had to add the set power level API and other stuff |
| return; | ||
| } | ||
|
|
||
| console.log(`Received request to set power level for bot ${userId} in room ${roomId}.`); |
|
LGTM aside from comment. |
|
LGTM |
The post message API now:
room_idspecified is not the one of the room currently being views.(@kegsay, I'm hoping you know how one could test this...)