This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement starter link support #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves modal dialogs because browsers are *terrible*.
| var body = HtmlUtils.bodyToHtml(content, this.props.highlights, {}); | ||
|
|
||
| if (this.props.highlightLink) { | ||
| body = <a href={ this.props.highlightLink }>{ body }</a>; | ||
| } | ||
| else if (content.data && typeof content.data["org.matrix.neb.starter_link"] === "string") { | ||
| // FIXME: React replaces this with a <span> because there is no href= - Matthew haaaalp! |
There was a problem hiding this comment.
i fix this by adding an href="#" and cancelling the event in the onClick.
|
lgtm other than comment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves modal dialogs because browsers are terrible. Also did a bit of refactoring, moving lots of Scalar specific stuff out of
RoomSettings.