This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Show session restore errors on the login screen #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are unable to load the matrix session on startup, don't just get stuck at a spinner; instead, show the error on the login screen.
| guestHsUrl: this.getCurrentHsUrl(), | ||
| guestIsUrl: this.getCurrentIsUrl(), | ||
| defaultDeviceDisplayName: this.props.defaultDeviceDisplayName, | ||
| q().then(() => { |
There was a problem hiding this comment.
i'm a little confused as to why we have to wrap the .loadSession in a q().then() rather than just just doing loadSession.catch().done()? Might be worth commenting it given the subtlety.
|
lgtm mod comment |
|
@ara4n: I added a comment. Does it make sense to you? |
|
it does indeed - thanks :) lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are unable to load the matrix session on startup, don't just get stuck at
a spinner; instead, show the error on the login screen.