Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Refreshing compact timeline layout #4335

Closed
wants to merge 6 commits into from
Closed

Refreshing compact timeline layout #4335

wants to merge 6 commits into from

Conversation

Fnux
Copy link

@Fnux Fnux commented Apr 2, 2020

Fixes element-hq/element-web#12998.

  • Moves useCompactLayout setting to preferences tab.
  • Remove avatar from compact layout.
  • Make replies compact.

I'm still not completly convinced by the updated layout: I'll try to gather some feedback here and there and update if needed.

Before:
Screenshot from 2020-04-02 14-29-25

After:
Screenshot from 2020-04-02 14-26-42

@jryans jryans changed the title WIP: Resfreshing compact timeline layout WIP: Refreshing compact timeline layout Apr 2, 2020
@Fnux
Copy link
Author

Fnux commented Apr 2, 2020

Note from @tulir: sync with #3553 so that we don't break each other.

@turt2live
Copy link
Member

@Fnux can you provide a link to a compiled version of this Riot for our design team to review?

@Fnux
Copy link
Author

Fnux commented Apr 3, 2020

Aligned a few things:

Screenshot from 2020-04-03 11-05-22

@Fnux
Copy link
Author

Fnux commented Apr 3, 2020

@Fnux can you provide a link to a compiled version of this Riot for our design team to review?

Here: https://staticwebhosting.ungleich.ch/~fnux/riot-compact/webapp/

@turt2live turt2live requested a review from a team April 3, 2020 16:03
@Fnux Fnux changed the title WIP: Refreshing compact timeline layout Refreshing compact timeline layout Apr 7, 2020
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Principally the proposal seems fine, but I'm getting really bad issues where:

  • When toggling on, my timeline spends a few seconds first before it changes layout reliably
  • When toggling off, avatars don't re-appear in the timeline

Can we make those 2 behaviours more reliable first before merging?

@Fnux
Copy link
Author

Fnux commented Apr 17, 2020

Principally the proposal seems fine, but I'm getting really bad issues where:

  • When toggling on, my timeline spends a few seconds first before it changes layout reliably
  • When toggling off, avatars don't re-appear in the timeline

Can we make those 2 behaviours more reliable first before merging?

Ack, I'll patch these two issues at some point in the next few days.

@jryans
Copy link
Collaborator

jryans commented Jun 5, 2020

@Fnux, are you still interested in working on this?

@Fnux
Copy link
Author

Fnux commented Jun 6, 2020

Similar to my other merge request: I'll eventually complete but a lot of things are happening on my side/work these days so it has been delayed.

When toggling on, my timeline spends a few seconds first before it changes layout reliably
When toggling off, avatars don't re-appear in the timeline

I'll have to find a way to reload the displayed room when toggling the setting, but have no clue at the moment.

@novocaine
Copy link
Contributor

Unfortunately this PR is stale at this point as it's gone quite out of sync with trunk. I'm going to have to close it as part of our ongoing efforts to clean up the repository.

@novocaine novocaine closed this Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp "compact timeline" mode
5 participants