This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't download E2E devices if feature disabled #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user hasn't enabled the E2E setting in the labs, there is no point in firing off the device download request when the MemberInfo is opened.
| // feature is enabled in the user settings | ||
| this._enableDevices = MatrixClientPeg.get().isCryptoEnabled() && | ||
| UserSettingsStore.isFeatureEnabled("e2e_encryption"); | ||
|
|
There was a problem hiding this comment.
This should probably be in componentWillMount really, as I think you'll be be testing it and getting undefined on the first render call.
|
otherwise lgtm |
... to avoid referencing it in render() before it is set
suiluj482
added a commit
to suiluj482/matrix-react-sdk
that referenced
this pull request
Mar 6, 2024
* Add Setting "Space.showIndirectRoomsInSpace" (matrix-org#418) * Changed SpaceFilterCondition and its tests to comply with new setting * Changed SpaceStore to watch new setting and if updated emit event SpaceFilterCondition already listens for. Added a test for it. Signed-off-by: Julius Schuchert <84525736+suiluj482@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user hasn't enabled the E2E setting in the labs, there is no point in
firing off the device download request when the MemberInfo is opened.