This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Set initial_device_display_name on login and register #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let Vector pass in a default device name, and thread it through everywhere to set it on login and register calls
| @@ -185,6 +185,7 @@ module.exports = React.createClass({ | |||
| enableGuest: this.props.enableGuest, | |||
| guestHsUrl: this.getCurrentHsUrl(), | |||
| guestIsUrl: this.getCurrentIsUrl(), | |||
| defaultDisplayName: this.props.config.default_device_name, | |||
There was a problem hiding this comment.
This could do with being in propTypes (especially as it would be good to doc what happens when it's undefined, although presumably this is up to the Home Server?). Also it should probably be in camelCase to be consistent with the other props.
Oh, although that said, it's within the config rather than a prop itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Vector pass in a default device name, and thread it through everywhere to
set it on login and register calls