This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Better support for inviting multiple people #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasting a list of addresses into the box will now pop up a dialog to confirm and show you the success / failure state of each address. It will also not die if it gets rate limited. Fixes element-hq/element-web#1713
| } | ||
| } | ||
| }).finally(function() { | ||
| self.setState({ |
There was a problem hiding this comment.
this looks redundant? it will be done by the finally?
Duplicated in `finally`
We now set them in the constructor
So that we can sensibly track the number completed by taking the length of it.
And make it actually cancel the process.
|
ptal |
| @@ -41,20 +42,28 @@ export default class MultiInviteDialog extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| componentWillUnmount() { | |||
| this._unmounted = true; | |||
There was a problem hiding this comment.
should we also be setting _canceled here? What happens if the user closes the dialog without clicking 'cancel'? I'm a bit confused about the difference between _unmounted and _canceled, and why we handle them differently in _inviteMore. Perhaps some comments would help?
There was a problem hiding this comment.
Point - it should definitely cancel if you dismiss the dialog so I've just made them the same variable.
Instead of both that and _unmounted
|
lgtm except for the build failure |
This was referenced Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pasting a list of addresses into the box will now pop up a dialog to confirm and show you the success / failure state of each address. It will also not die if it gets rate limited.
Fixes element-hq/element-web#1713
Requires: element-hq/element-web#1942