This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Start to factor out session-loading magic #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take some of the magic out of MatrixChat.componentDidMount() into a new component. Also delete the MatrixChat test. It wasn't really doing much, is broken by the change, and I am replacing it with (better) app-level tests in the vector project.
|
Feels a little odd this being in a react component when it's UI is just a spinner - is there a reason it's not just a class with the Also, if it is a react component, is there a reason it's loaded directly, bypassing the skin? |
Er, no. good point. will update it. |
There's no point in it being a React component.
richvdh
force-pushed
the
rav/factor_out_sessionloader
branch
from
bd1d46e
to
26c7c9e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take some of the magic out of MatrixChat.componentDidMount() into a new component.
There will be more of this; there is some in vector/index.js, and more in MatrixClientPeg, but I wanted to start here :)
Also delete the MatrixChat test. It wasn't really doing much, is broken by the change, and I am replacing it with (better) app-level tests in the vector project.