This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Refactor MatrixClientPeg #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be functionally identical
| this.matrixClient.getAccessToken(), | ||
| this.guestAccess.isGuest(), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
This isn't actually used yet & probably should have been in the next PR really
|
The guestAccess thing confuses me. |
Including getting rid of GuestAccess as it was basically doing nothing apart from remembering if we were a guest which may as well be done in the same place we save/restore everything else
|
Okay, I've removed the GuestAccess thing that was confusing @richvdh (and me). ptal. |
| replaceUsingUrls(hs_url, is_url) { | ||
| this.replaceClient(hs_url, is_url); | ||
| this.replaceUsingAccessToken(hs_url, is_url); |
There was a problem hiding this comment.
FWIW, it felt weird to me to have replaceUsingUrls call replaceUsingAccessToken with no access_token, which was why I created replaceClient. But I don't feel strongly.
|
much better. lgtm modulo minor suggestion |
Reintroduce replaceClient so we're not calling replaceUsingAccessToken without access tokens which is a bit silly. Fix bug from previous commit (pass isGuest through)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be functionally identical
Edit: actually now not quite functionally identical as it used to remember what room it was peeking into and then start the peeking again, but I don't see how this was ever useful for anything.