This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix integration manager not updating when set #3510
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setUserWidget was modifying the content of the old event itself, so when `waitForUserWidget()` checked the content to see if it was there yet, it was, but because the echo hadn't come back, the IntegrationManager hadn't rebuilt its list. In other news, its terrifying that we can just accidentally modify the content of an event in the store. I'm going to make a js-sdk PR that freezes the content and see what breaks... Fixes element-hq/element-web#10977
jryans
reviewed
Oct 2, 2019
| const userWidgets = WidgetUtils.getUserWidgets(); | ||
| // Get the current widgets and clone them before we modify them, otherwise | ||
| // we'll modify the content of the old event. | ||
| const userWidgets = JSON.parse(JSON.stringify(WidgetUtils.getUserWidgets())); |
There was a problem hiding this comment.
Object.assign({}, thingToClone) should also work and skips the overhead of JSON in the middle.
There was a problem hiding this comment.
yeah, although only shallow, although that would probably suffice in this case...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setUserWidget was modifying the content of the old event itself,
so when
waitForUserWidget()checked the content to see if it wasthere yet, it was, but because the echo hadn't come back, the
IntegrationManager hadn't rebuilt its list.
In other news, its terrifying that we can just accidentally modify
the content of an event in the store. I'm going to make a js-sdk
PR that freezes the content and see what breaks...
Fixes element-hq/element-web#10977