Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Make Autocomplete more accessible to screen reader users #3497

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 30, 2019

Fixes element-hq/element-web#10900

Use ARIA to:

  • notate that the composer has an autocomplete
  • notate the open/closed state of the autocomplete
  • notate the name of the open autocomplete options
  • notate the ID of the highlighted autocomplete option
  • improve naming of emoji autocomplete options for screen readers

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Does NOT implement:

There's no indication that an autocomplete appeared.

Use ARIA to:
 + notate that the composer has an autocomplete
 + notate the open/closed state of the autocomplete
 + notate the name of the open autocomplete options
 + notate the ID of the highlighted autocomplete option
 + improve naming of emoji autocomplete options for screen readers

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member Author

t3chguy commented Sep 30, 2019

Note, this is only implemented for CIDER. For Slate this is impossible at this time due to: ianstormtaylor/slate#2572

@t3chguy t3chguy requested a review from a team September 30, 2019 13:42
@dbkr dbkr requested review from dbkr and removed request for a team October 1, 2019 10:56
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really promising - thanks!

@t3chguy t3chguy merged commit 2d6461d into develop Oct 1, 2019
@t3chguy t3chguy deleted the t3chguy/autocomplete_a11y branch April 27, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete unhelpful for screen readers
2 participants