Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wrap deactivation check with sanity conditions #3437

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

turt2live
Copy link
Member

To ensure the matrixClient is not null (the problem) and that unexpected errors don't brick the app.

Fixes element-hq/element-web#10854

To ensure the matrixClient is not null (the problem) and that unexpected errors don't brick the app.

Fixes element-hq/element-web#10854
@turt2live turt2live requested a review from a team September 13, 2019 00:32
@turt2live turt2live added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Sep 13, 2019
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/components/views/rooms/MemberInfo.js Outdated Show resolved Hide resolved
@bwindels
Copy link
Contributor

Also, happened in the previous PR, but _calculateCanPermissions doesn't need to be async anymore.

@turt2live turt2live merged commit e18b38c into develop Sep 13, 2019
@turt2live turt2live deleted the travis/fix-deactivate branch September 13, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devices section of MemberInfo permaspins on 1.3.5
2 participants