Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show canonical alias in URL bar #314

Merged
merged 2 commits into from
Jun 17, 2016
Merged

Show canonical alias in URL bar #314

merged 2 commits into from
Jun 17, 2016

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 17, 2016

Use matrix-org/matrix-js-sdk#140 to get the canonical alias, because that's a thing now.

Use matrix-org/matrix-js-sdk#140 to get the canonical alias, because that's a thing now.
@richvdh
Copy link
Member

richvdh commented Jun 17, 2016

Hrm.

  1. should we fall back to a (semi-random) m.room.aliases alias if there is no canonical_alias in the room?
  2. Should we get rid of MatrixTools.getCanonicalAliasForRoom? (or update it in light of point 1 and continue to use it)?

@richvdh richvdh assigned dbkr and unassigned richvdh Jun 17, 2016
@dbkr
Copy link
Member Author

dbkr commented Jun 17, 2016

Oh, yes - I was actually going to get rid of all of MatrixTools as the only other use is getting a room from an alias somewhere else, which is also wrong. This should still delete this from the file though.

@dbkr dbkr assigned richvdh and unassigned dbkr Jun 17, 2016
@dbkr
Copy link
Member Author

dbkr commented Jun 17, 2016

ptal

@richvdh richvdh merged commit 1d42443 into develop Jun 17, 2016
@richvdh richvdh deleted the dbkr/show_canonical_alias branch February 15, 2017 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants