This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add experimental "Labs" section to settings #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,4 +112,14 @@ module.exports = { | |||
| append: true, // We always append for email pushers since we don't want to stop other accounts notifying to the same email address | |||
| }); | |||
| }, | |||
|
|
|||
| isFeatureEnabled: function(feature: string): boolean { | |||
| feature = feature.match(/\w+/g).join('_').toLowerCase(); | |||
There was a problem hiding this comment.
Not sure I'm a big fan of the magic here - I'd prefer LABS_FEATURES to just be an object.
Edit: Also, if we're using underscored strings as keys under the hood I'd have thought we should use them as the parameter to these functions too.
There was a problem hiding this comment.
Yes, that's how they're intended to be used -- with underscored strings (which remain the same after this magic.)
|
Other than that, looking good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.