Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support for marking devices as verified #300

Merged
merged 6 commits into from
Jun 9, 2016
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 8, 2016

Add device info to the MemberInfo, and to the User settings, and add a way to
mark other devices as verified.

Check if the device is verified when displaying encrypted events, and add a CSS
class accordingly.

Requires matrix-org/matrix-js-sdk#136

Requires e81ce23 from matrix-js-sdk
Requires e81ce23 in matrix-js-sdk
Add a couple of CSS classes to event tiles to reflect whether encrypted events
have been verified or not.
Use the dispatcher to update event tiles and memberdeviceinfo when a device is
marked as verified.

onAction: function(payload) {
switch (payload.action) {
case 'device_verified':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ultimate plan to store device verifications on the home server & sync them between devices? If so, presumably this should be an event that comes out of the client so a client can update if you verify someone's device from another of your devices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum; I hadn't thought about that. The problem is that a naive approach means that the HS could fiddle with the list of devices you trust. I suppose we need this, but there would have to be some sort of signing. Either way, it's not going to happen for a while.

I guess it makes sense to raise this as a js-sdk event anyway.

@dbkr
Copy link
Member

dbkr commented Jun 8, 2016

Couple of comments, but all things that can come later: as a first version, lgtm.

@dbkr dbkr assigned richvdh and unassigned dbkr Jun 8, 2016
We'll probably want to be able to bubble up device verifications from the
js-sdk at some point, so let's use a js-sdk event for this.
@richvdh
Copy link
Member Author

richvdh commented Jun 8, 2016

@dbkr: ptal?

@dbkr
Copy link
Member

dbkr commented Jun 9, 2016

That should do it :) lgtm

@dbkr dbkr removed their assignment Jun 9, 2016
@richvdh richvdh merged commit ef764c1 into develop Jun 9, 2016
@richvdh richvdh deleted the rav/device_verification branch June 9, 2016 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants