This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Hopefully fix memory leak with velocity #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huh? We aren't using jquery are we? |
| @@ -25,6 +25,10 @@ module.exports = React.createClass({ | |||
| this._updateChildren(this.props.children); | |||
| }, | |||
|
|
|||
| componentWillUnmount: function() { | |||
| this._updateChildren([]); | |||
There was a problem hiding this comment.
surely this doesn't do anything? it just sets this.children = {}, which has no effect, because render won't be called again? Or am I missing something
There was a problem hiding this comment.
Actually yes, this shouldn't be necessary.
|
We're not using jQuery, but Velocity does (or in this case it uses its own, small jQuery replacement which stores data alongside elements in a compatible way. |
|
ptal |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we should be doing this anyway because apparently you need to blow away the jQuery data manually if your DOM nodes are not removed using jQuery's node.remove()...