Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Only show hosting link if domain == matrix.org #2754

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 6, 2019

@dbkr dbkr requested a review from a team March 6, 2019 10:24
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be if the HS is the default, so that then it can actually be controlled via config,json

Otherwise what if I'm some other big HS running my own Modular-like service, I'd have to modify the source

@jryans jryans self-assigned this Mar 6, 2019
@jryans
Copy link
Collaborator

jryans commented Mar 6, 2019

Maybe it should be if the HS is the default

It's currently slightly tricky to do today, since both default_hs_url and default_server_name can impact this. Checking MatrixChat's defaultHsUrl state should be correct, but that's not so easy to access where needed at the moment. I'd suggest filing for a future improvement if it's desired for others too.

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! We should think about how to evolve this so it's not specific to just matrix.org, assuming others want something like that.

@jryans jryans assigned dbkr and unassigned jryans Mar 6, 2019
@dbkr
Copy link
Member Author

dbkr commented Mar 6, 2019

Plus anyone who hosts their own HS + Riot will set thew default HS to their HS and they don't want to be directing people to other hosting.

@dbkr dbkr merged commit 9a57e5c into release-v1.0.2 Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants