This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Always insert rooms into lists when they get lost #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Room upgrades, direct chats, etc all end up being lost in these scenarios. Instead of losing them to the list, try and put them into a relevant spot of the list. Fixes element-hq/element-web#9020
jryans
reviewed
Mar 1, 2019
src/stores/RoomListStore.js
Outdated
| } | ||
| } else { | ||
| insertedIntoTags.push(key); | ||
| // There's some circumstances where the room doesn't fit anywhere, so just |
There was a problem hiding this comment.
I think it would be good to detail here what the circumstance are, if we know them now.
There was a problem hiding this comment.
It's almost always "ran off the list" - I've adjusted the approach to instead try and fix this more calmly.
jryans
reviewed
Mar 1, 2019
| insertedIntoTags.push(key); | ||
| } else { | ||
| // In theory, this should never happen | ||
| console.warn(`!! Room ${room.roomId} lost: No position available`); |
There was a problem hiding this comment.
Is it worth keeping some kind of logging that it would have been lost without this new fallback? (Do we hope to do something better in the future?)
There was a problem hiding this comment.
Absolutely - have added a bunch of logging
Instead of having a catch-all insert, try and fix the common cases with a bit more care.
jryans
approved these changes
Mar 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Room upgrades, direct chats, etc all end up being lost in these scenarios. Instead of losing them to the list, try and put them into a relevant spot of the list.
Fixes element-hq/element-web#9020
Demo:
Repeating the steps without this patch results in rooms disappearing from the room list.