Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add missing permalinkCreator prop #2729

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 1, 2019

Might fix element-hq/element-web#8995
its the only missing permalinkCreator I found but could not repro the Failed prop type warning locally in the first place.

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team March 1, 2019 09:37
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@t3chguy t3chguy merged commit 6b0b5e4 into develop Mar 4, 2019
@t3chguy t3chguy deleted the t3chguy/missing_permalinkCreator branch May 25, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

permalinkCreator is marked as required in ReplyThread but it is undefined
2 participants