This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move complex part of room sorting to a dedicated function #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty much cut/pasting it in, as there's not really a whole much to help make the code more understandable here. This also includes a comment block longer than the code it describes in hopes it explains away the problem of understanding what it does. Should fix element-hq/element-web#8861
bwindels
approved these changes
Feb 28, 2019
src/stores/RoomListStore.js
Outdated
| const targetCategoryIndex = CATEGORY_ORDER.indexOf(category); | ||
|
|
||
| // The slotting algorithm works by trying to position the room in the most relevant | ||
| // section of the list (red > grey > etc). To accomplish this, we need to consider |
There was a problem hiding this comment.
The terms section and category seem to be used interchangeably. Can we settle on either of them?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much cut/pasting it in, as there's not really a whole much to help make the code more understandable here.
This also includes a comment block longer than the code it describes in hopes it explains away the problem of understanding what it does.
Should fix element-hq/element-web#8861