Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix Room Directory custom homeserver entry not showing properly #2708

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 26, 2019

I have no idea what the hell happened in this file but there were a LOT of conflicting identifiers,
selectedInstance vs selectedInstanceId
includeAll vs includeAllNetworks
the initial State made no sense
custom entry behaviour was mismatched

Fixes element-hq/element-web#7364

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy changed the title Fix Room Directory custom homeserver entry not showing propely Fix Room Directory custom homeserver entry not showing properly Feb 26, 2019
@t3chguy t3chguy requested a review from a team February 26, 2019 23:27
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable to me! 😁

There seem to be various linting errors in this file (span_class unused, etc.), so if you'd like, feel free to remove from .eslintignore.errorfiles and clean it up where you're here.

@t3chguy
Copy link
Member Author

t3chguy commented Feb 27, 2019

There seem to be various linting errors in this file (span_class unused, etc.), so if you'd like, feel free to remove from .eslintignore.errorfiles and clean it up where you're here.

Will do :)

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy assigned jryans and unassigned t3chguy Mar 4, 2019
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the linting clean up here! 😁

@jryans jryans assigned t3chguy and unassigned jryans Mar 4, 2019
@t3chguy t3chguy merged commit 080c674 into develop Mar 4, 2019
@t3chguy t3chguy deleted the fix_room_dict branch May 25, 2020 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants